This repository was archived by the owner on May 31, 2025. It is now read-only.
roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters#1502
Closed
peci1 wants to merge 5 commits intoros:melodic-develfrom
Closed
roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters#1502peci1 wants to merge 5 commits intoros:melodic-develfrom
peci1 wants to merge 5 commits intoros:melodic-develfrom
Conversation
Contributor
Author
|
Hmm, the test failures seem to be unrelated... |
|
+1, that would be very appreciated and time-saving :) |
Member
|
The patch removes the previously (private) constants and duplicates the values |
Contributor
Author
|
Closing in favor of #1670. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1493 by adding roslaunch CLI options
--sigint-timeoutand--sigterm-timeout. The timeouts are common to all nodes launched by this command. It would be possible to customize them per-node, but that would require changing the XML tags, and I'm not sure if it'd be useful at all.It needed an unexpectedly big change to the codebase, but mainly it was just adding and passing keyword arguments of methods, so the API should be backwards compatible (every added kw argument has a default value).
I added unit tests for the local nodes, however, I haven't figured out any other way of testing this than really launching and stopping nodes, so the newly added tests need about 20 seconds to run... I hope it's not a big problem...
I also haven't figured out how to do automatic testing of the remote launch, but it seems that it's not tested at all. So I at least added a script you can run manually in case you have a second machine set up for remote launching. This test passed on my machine.
Theoretically, it should work also on Windows, but I haven't tested that.