This repository was archived by the owner on May 31, 2025. It is now read-only.
rostest: use AnyMsg in publishtest#1659
Merged
dirk-thomas merged 2 commits intoros:melodic-develfrom Mar 26, 2019
beetleskin:fix_publishtest
Merged
rostest: use AnyMsg in publishtest#1659dirk-thomas merged 2 commits intoros:melodic-develfrom beetleskin:fix_publishtest
dirk-thomas merged 2 commits intoros:melodic-develfrom
beetleskin:fix_publishtest
Conversation
dirk-thomas
reviewed
Mar 15, 2019
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
Please create separate PRs for unrelated changes: one for the rospy.AnyMsg change and one for the retry flag to address the flakiness.
Contributor
Author
|
Done, anything missing? |
Member
|
LGTM. Thanks for the patch. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
* publishtest: use AnyMsg in publishtest * fix concerns
Contributor
Author
|
any plans to release this? |
Member
See #1802. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now publishtest only works correctly when a publisher of the given topic exists: If no publisher exists, the retrieval of the topic class blocks until the test times out. This leads to aborted tests when one would expect a failed one with correct error message, stating that no message on the given topic was published. Using rospy.AnyMsg fixes that.
This also makes it impossible to test that a certain topic is not being published, when no publisher exists.