This repository was archived by the owner on May 31, 2025. It is now read-only.
/libros/node_handle: keep shared pointer to TopicManager and ServiceM…#1630
Closed
cwecht wants to merge 3 commits intoros:melodic-develfrom
Closed
/libros/node_handle: keep shared pointer to TopicManager and ServiceM…#1630cwecht wants to merge 3 commits intoros:melodic-develfrom
cwecht wants to merge 3 commits intoros:melodic-develfrom
Conversation
…anager to avoid boost::lock_error exceptions
This was referenced Feb 23, 2019
Contributor
Author
|
Well, this failed because of the flakyness of topic_tools throttle.test ... |
scott-eddy
reviewed
Feb 27, 2019
|
This looks good to me |
Contributor
Author
|
Alternatively, the shared_ptrs could be added NodeHandleBackingCollection. This would also avoid an API break. Since order of destruction of global object can be an issue, this might be a better solution. |
Contributor
Author
|
The above mentioned alternative is astonishingly simple: cwecht@39b9938 This might actually be a better solution. The solution of this PR relies (probably?) on specific destruction order of globals/statics, which is unfortunate. The alternative version ensures, that the managers live at least as long as any NodeHandle-instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…anager to avoid boost::lock_error exceptions.
Fixes #838.
This solution does not change the object-layout of NodeHandle.