Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Rename python message_filters.Cache.getLastestTime to getLatestTime#1450

Merged
dirk-thomas merged 2 commits intoros:melodic-develfrom
madebyollin:melodic-devel
Aug 3, 2018
Merged

Rename python message_filters.Cache.getLastestTime to getLatestTime#1450
dirk-thomas merged 2 commits intoros:melodic-develfrom
madebyollin:melodic-devel

Conversation

@madebyollin
Copy link
Copy Markdown
Contributor

@madebyollin madebyollin commented Jul 6, 2018

Per instructions from dirk-thomas on this issue: #1449 (comment)

@madebyollin madebyollin mentioned this pull request Jul 6, 2018
Closed
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Jul 9, 2018

@ros-pull-request-builder retest this please

@madebyollin
Copy link
Copy Markdown
Contributor Author

madebyollin commented Jul 13, 2018

Reading the test outputs, it's still not clear which test failures (if any) are related to the changes in this PR. Some of them (e.g. test_random_play, __main__.HzTest.test_hz) are also failing on unrelated PRs. Others (e.g. Subscriptions.emptyMsg) are in the roscpp tests, and the code changes in this PR only affect the python interface. None seem to reference code I changed... It's difficult for me to interpret the tests without prior knowledge about the test structure/test behavior on previous builds, though.

If any of the test failures do indicate bugs in this PR, please let me know and I can try to fix them. Otherwise, it should hopefully be straightforward to merge these edits. Thanks!

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 3, 2018

Thank you for the patch.

@dirk-thomas dirk-thomas merged commit 8341716 into ros:melodic-devel Aug 3, 2018
dirk-thomas pushed a commit that referenced this pull request Aug 9, 2018
@madebyollin @dirk-thomas
Rename python message_filters.Cache.getLastestTime to getLatestTime (#…
f92e9e3 
…1450)

* Rename getLastestTime to getLatestTime

Per directions [here](#1449 (comment)).

* Test getLatestTime instead of getLastestTime

per #1449 (comment)
@dirk-thomas dirk-thomas mentioned this pull request Aug 9, 2018
Merged
dirk-thomas pushed a commit that referenced this pull request Aug 20, 2018
@madebyollin @dirk-thomas
Rename python message_filters.Cache.getLastestTime to getLatestTime (#…
b1d1dd4 
…1450)

* Rename getLastestTime to getLatestTime

Per directions [here](#1449 (comment)).

* Test getLatestTime instead of getLastestTime

per #1449 (comment)
@dirk-thomas dirk-thomas mentioned this pull request Aug 20, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madebyollin @dirk-thomas