Fix some errors in some probably not frequented code paths melodic#1415
Conversation
|
#1410 had some additional changes. Are they not applicable to the Melodic branch? Should they be pull requested against an older branch only? If yes, which one would be newest distro which needs those?
All patches are considered for backporting. Since this fixes obvious bugs it will very likely be backported for the next patch release. |
|
That are not applicable as the error was fixed already (variable "uri" not
existing in the scope).
So if the file gets backported as it is (which looks more correct) it
should be all fine.
…On Thu, May 31, 2018, 02:23 Dirk Thomas ***@***.***> wrote:
#1410 <#1410> had some additional
changes. Are they not applicable to the Melodic branch? Should they be pull
requested against an older branch only? If yes, which one would be newest
distro which needs those?
Are you gonna backport to Kinetic also?
All patches are considered for backporting. Since this fixes obvious bugs
it will very likely be backported for the next patch release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1415 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABpFdNCxGidN9KqrUL2tLoBROJiFR04wks5t3sdxgaJpZM4UTgB7>
.
|
The "file" doesn't get backported only the applied patches get cherry-picked to the older branches. So if older distros need additional fixes please create a separate PR for that targeting the branch with the most recent distro which needs the fix. |
|
Ok, I'll need a bit of time to apply the same change to previous
branches/distros (other than kinetic and melodic).
Can you reopen the previous PR and re-target it for kinetic again maybe?
I'll take a look at other branches/distros soon.
2018-05-31 12:19 GMT+10:00 Dirk Thomas <notifications@github.com>:
… So if the file gets backported as it is (which looks more correct) it
should be all fine.
The "file" doesn't get backported only the applied patches get
cherry-picked to the older branches.
So if older distros need additional fixes please create a separate PR for
that targeting the branch with the most recent distro which needs the fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1415 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABpFdKMIeNoaMd7qkNcR6k_RrmCpakKfks5t31M7gaJpZM4UTgB7>
.
|
|
I opened PR on all in-development distros. Indigo and Kinetic have the same changes. Lunar and Melodic have the same changes. I don't know what's the process to apply the same change to all the branches, sorry if this is not in your expected format. |
|
Thanks for the patch! |
Update to #1410
Are you gonna backport to Kinetic also?