Specialize BagCallbackT for MessageInstance#1374
Specialize BagCallbackT for MessageInstance#1374mikepurvis merged 2 commits intoros:melodic-develfrom
Conversation
|
FYI @dirk-thomas |
408ad60 to
ec366a6
Compare
|
Looks reasonable— related to #1372 in terms of overall objective, though that one is for the filter command whereas this is the C++ bag API. 👍 |
|
@ros-pull-request-builder retest this please |
|
Since this is a header-only change, a CI pass isn't super meaningful. It's certainly not a complicated implementation, but I wonder if there might be some kind of trivial test which could be added to test_rosbag_storage? |
And call the callback directly with the MessageInstance, so the client callback can access the connection information. This is useful when processing a bag file to create a new one b/c we can keep the message time and connection information, e.g. the latch property.
ec366a6 to
fbd5fe7
Compare
|
@mikepurvis I agree, I'd add a test to |
|
@efernandez It gets written as part of the test: ros_comm/test/test_rosbag_storage/src/swap_bags.cpp Lines 9 to 12 in e96c407 |
|
Thanks. I've just added a unit test (creating a simple test bag on runtime as the other tests in this package do). |
c64a0ef to
2dee8c6
Compare
2dee8c6 to
e9c4819
Compare
|
@ros-pull-request-builder retest this please |
|
Remaining failures are known-flaky. Thanks for this contribution! |
Specialize
BagCallbackTforMessageInstanceso the overloadedcallmethod calls the callback directly with theMessageInstanceobject.This way the client callback can access the connection information, which is useful when processing a bag file to create a new one b/c then we can keep the message time and connection information, e.g. the latch property.