This repository was archived by the owner on May 31, 2025. It is now read-only.
keep connection header information in rosbag operations (#679, #685)#1372
Merged
mikepurvis merged 1 commit intoros:melodic-develfrom Apr 24, 2018
Merged
Conversation
14a504a to
51d3842
Compare
Member
|
Looks like a good change; I've rebased it onto |
Member
|
Remaining failure on Bionic is a known-flaky test. LGTM. |
|
Will this be seen in kinetic, or just melodic? |
dirk-thomas
reviewed
Aug 3, 2018
| raise NotImplementedError() | ||
|
|
||
| def read_messages(self, topics, start_time, end_time, connection_filter, raw): | ||
| def read_messages(self, topics, start_time, end_time, connection_filter, raw, return_connection_header): |
Member
There was a problem hiding this comment.
There is no reason to break the API signature here. The new argument should be made optional. See first commit on #1473.
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for the issue that
rosbag filter&rosbag compressremoves latching information from topic connection headers.See #679 for a nice description. This PR is based on that discussion, but follows a slightly different implementation.
You can see the difference by using this script (the script needs the patched code to access the bag headers):