This repository was archived by the owner on May 31, 2025. It is now read-only.
Take XmlRpcValue by *const* ref. in operator<<#1350
Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom Mar 16, 2018
Merged
Take XmlRpcValue by *const* ref. in operator<<#1350dirk-thomas merged 1 commit intoros:lunar-develfrom
dirk-thomas merged 1 commit intoros:lunar-develfrom
Conversation
Contributor
Author
|
Sorry I can't add you directly as reviewers. |
Member
|
Would have to update here too, right? https://github.com/ros/ros_comm/blob/lunar-devel/utilities/xmlrpcpp/src/XmlRpcValue.cpp#L656-L661 |
This allows to use the operator<< also with const references to XmlRpcValue objects, not only non-const ones.
506d7a5 to
8a14ab8
Compare
Contributor
Author
|
Yes, I forgot that. It's fixed in both places now. Thanks. |
Member
|
Looks like there's a rosdep problem on Ubuntu causing the CI fail, but two of the jobs are still passing, so this is fine by me to be merged. 👍 |
mikepurvis
approved these changes
Mar 16, 2018
Member
|
It looks like the Ubuntu package |
Member
|
@ros-pull-request-builder retest this please |
Member
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Apr 3, 2018
This allows to use the operator<< also with const references to XmlRpcValue objects, not only non-const ones.
dirk-thomas
added a commit
that referenced
this pull request
Apr 3, 2018
This reverts commit 1fa062c.
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 20, 2018
This allows to use the operator<< also with const references to XmlRpcValue objects, not only non-const ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to use the
operator<<also with const references toXmlRpcValueobjects, not only non-const ones.