Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Raise the correct exception from AnyMsg.serialize#1311

Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom
drigz:anymsg-exception
Feb 1, 2018
Merged

Raise the correct exception from AnyMsg.serialize#1311
dirk-thomas merged 1 commit intoros:lunar-develfrom
drigz:anymsg-exception

Conversation

@drigz
Copy link
Copy Markdown
Contributor

@drigz drigz commented Jan 19, 2018

Previously, this was causing TypeError: 'module' object is not callable, which was not noticed due to the bare except: in the test.

I wasn't able to run the tests, so I'm relying on CI to test that part of the change. I tried running them within a ros:lunar docker container with:

catkin_make --pkg ros_comm
catkin_make run_tests_test_rospy_rostest

but got lots of errors like:

  File "/catkin_ws/src/ros_comm/clients/rospy/src/rospy/client.py", line 68, in <module>
    from roscpp.srv import GetLoggers, GetLoggersResponse, SetLoggerLevel, SetLoggerLevelResponse
ImportError: No module named srv

Previously, this was causing `TypeError: 'module' object is not
callable`, which was not noticed due to the bare `except:` in the test.
@dirk-thomas
Copy link
Copy Markdown
Member

Thank you for the patch.

In the future please see the buildfarm documentation on how to reproduce the same build locally: https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/devel_jobs.rst#run-the-devel-job-locally

@dirk-thomas dirk-thomas added the bug label Feb 1, 2018
@dirk-thomas dirk-thomas merged commit 6051daa into ros:lunar-devel Feb 1, 2018
dirk-thomas pushed a commit that referenced this pull request Feb 9, 2018
Previously, this was causing `TypeError: 'module' object is not
callable`, which was not noticed due to the bare `except:` in the test.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants