This repository was archived by the owner on May 31, 2025. It is now read-only.
Raise the correct exception from AnyMsg.serialize#1311
Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom Feb 1, 2018
Merged
Raise the correct exception from AnyMsg.serialize#1311dirk-thomas merged 1 commit intoros:lunar-develfrom
dirk-thomas merged 1 commit intoros:lunar-develfrom
Conversation
Previously, this was causing `TypeError: 'module' object is not callable`, which was not noticed due to the bare `except:` in the test.
Member
|
Thank you for the patch. In the future please see the buildfarm documentation on how to reproduce the same build locally: https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/devel_jobs.rst#run-the-devel-job-locally |
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 9, 2018
Previously, this was causing `TypeError: 'module' object is not callable`, which was not noticed due to the bare `except:` in the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this was causing
TypeError: 'module' object is not callable, which was not noticed due to the bareexcept:in the test.I wasn't able to run the tests, so I'm relying on CI to test that part of the change. I tried running them within a
ros:lunardocker container with:but got lots of errors like: