Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

rosbag fails to compile on OS X with clang#13

Closed
wjwwood wants to merge 1 commit intomasterfrom
fix_clang_rosbag
Closed

rosbag fails to compile on OS X with clang#13
wjwwood wants to merge 1 commit intomasterfrom
fix_clang_rosbag

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Oct 22, 2012

When building rosbag from source on OS X with clang I get:

[ 80%] Building CXX object ros_comm/tools/rosbag/CMakeFiles/rosbag.dir/src/bag.cpp.o
In file included from /Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:28:
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:392:40: error: use of undeclared identifier 'CONNECTION_FIELD_NAME'
        readField(*header.getValues(), CONNECTION_FIELD_NAME, true, &connection_id);
                                       ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:425:27: error: use of undeclared identifier 'TOPIC_FIELD_NAME'
        readField(fields, TOPIC_FIELD_NAME,    true,  topic);
                          ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:426:27: error: use of undeclared identifier 'LATCHING_FIELD_NAME'
        readField(fields, LATCHING_FIELD_NAME, false, latching);
                          ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:427:27: error: use of undeclared identifier 'CALLERID_FIELD_NAME'
        readField(fields, CALLERID_FIELD_NAME, false, callerid);
                          ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:581:12: error: use of undeclared identifier 'OP_FIELD_NAME'
    header[OP_FIELD_NAME]         = toHeaderString(&OP_MSG_DATA);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:581:53: error: use of undeclared identifier 'OP_MSG_DATA'
    header[OP_FIELD_NAME]         = toHeaderString(&OP_MSG_DATA);
                                                    ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:582:12: error: use of undeclared identifier 'CONNECTION_FIELD_NAME'
    header[CONNECTION_FIELD_NAME] = toHeaderString(&conn_id);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/include/rosbag/bag.h:583:12: error: use of undeclared identifier 'TIME_FIELD_NAME'
    header[TIME_FIELD_NAME]       = toHeaderString(&time);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:197:44: error: use of undeclared identifier 'VERSION'
    string version = string("#ROSBAG V") + VERSION + string("\n");
                                           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:326:12: error: use of undeclared identifier 'OP_FIELD_NAME'
    header[OP_FIELD_NAME]               = toHeaderString(&OP_FILE_HEADER);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:326:59: error: use of undeclared identifier 'OP_FILE_HEADER'
    header[OP_FIELD_NAME]               = toHeaderString(&OP_FILE_HEADER);
                                                          ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:327:12: error: use of undeclared identifier 'INDEX_POS_FIELD_NAME'
    header[INDEX_POS_FIELD_NAME]        = toHeaderString(&index_data_pos_);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:328:12: error: use of undeclared identifier 'CONNECTION_COUNT_FIELD_NAME'
    header[CONNECTION_COUNT_FIELD_NAME] = toHeaderString(&connection_count_);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:329:12: error: use of undeclared identifier 'CHUNK_COUNT_FIELD_NAME'
    header[CHUNK_COUNT_FIELD_NAME]      = toHeaderString(&chunk_count_);
           ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:335:22: error: use of undeclared identifier 'FILE_HEADER_LENGTH'
    if (header_len < FILE_HEADER_LENGTH)
                     ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:336:20: error: use of undeclared identifier 'FILE_HEADER_LENGTH'
        data_len = FILE_HEADER_LENGTH - header_len;
                   ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:357:23: error: use of undeclared identifier 'OP_FILE_HEADER'
    if (!isOp(fields, OP_FILE_HEADER))
                      ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:361:23: error: use of undeclared identifier 'INDEX_POS_FIELD_NAME'
    readField(fields, INDEX_POS_FIELD_NAME, true, (uint64_t*) &index_data_pos_);
                      ^
/Users/william/devel/groovy/base/src/ros_comm/tools/rosbag/src/bag.cpp:368:27: error: use of undeclared identifier 'CONNECTION_COUNT_FIELD_NAME'
        readField(fields, CONNECTION_COUNT_FIELD_NAME, true, &connection_count_);
                          ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [ros_comm/tools/rosbag/CMakeFiles/rosbag.dir/src/bag.cpp.o] Error 1
make[1]: *** [ros_comm/tools/rosbag/CMakeFiles/rosbag.dir/all] Error 2
make: *** [all] Error 2

Odd enough, the workaround seems to be to rename the rosbag/constants.h to rosbag/rosbag_constants.h and change any references to it. I don't know what is causing this, but this work arounds seems to fix it and is harmless.

I will attach a pull request asap.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Nov 21, 2012

Can you retry that with the current state? May be it was related to the previously broken include directory order. If it is not already fixed we could merge the patch (but I would prefer to understand why that happens to not run into the same issue again in the future).

@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Dec 3, 2012

This is no longer an issue.

@wjwwood wjwwood closed this Dec 3, 2012
@tfoote tfoote mentioned this pull request Jan 31, 2013
Closed
@dirk-thomas dirk-thomas deleted the fix_clang_rosbag branch February 5, 2014 10:13
johnsonshih added a commit to johnsonshih/ros_comm that referenced this pull request Sep 20, 2018
@johnsonshih
Merge pull request ros#13 from johnsonshih/optional-resource_retriever
ffc69f0 
Make resource-retriever optional
@rishabh900 rishabh900 mentioned this pull request Sep 17, 2019
Closed
@meng-atomic meng-atomic mentioned this pull request Jul 3, 2020
Closed
@Sunriseyms Sunriseyms mentioned this pull request Dec 29, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wjwwood @dirk-thomas