Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

rosbag record: Add TransportHint options --tcpnodelay and --udp#1295

Merged
mikepurvis merged 1 commit intoros:melodic-develfrom
alspitz:feature/record_udp_nodelay
Apr 23, 2018
Merged

rosbag record: Add TransportHint options --tcpnodelay and --udp#1295
mikepurvis merged 1 commit intoros:melodic-develfrom
alspitz:feature/record_udp_nodelay

Conversation

@alspitz
Copy link
Copy Markdown
Contributor

@alspitz alspitz commented Jan 2, 2018

No description provided.

@alspitz alspitz changed the title Add TransportHint options --tcpnodelay and --udp rosbag record: Add TransportHint options --tcpnodelay and --udp Jan 2, 2018
@alspitz alspitz mentioned this pull request Jan 2, 2018
Closed
@romainreignier
Copy link
Copy Markdown

romainreignier commented Jan 22, 2018

I have tested this PR, it works well and should be merged I think.

Recording messages at 200Hz, they were packed and the replay was erroneous. Now it simply works.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Feb 1, 2018

Thank you for contributing this patch.

Since it changes ABI I will mark it to be included in the next ROS distro which will be Melodic.

@ArekSredzki
Copy link
Copy Markdown

ArekSredzki commented Mar 11, 2018

@dirk-thomas Could this change please be backported to kinetic? It would be remarkably useful.

@mikepurvis mikepurvis changed the base branch from lunar-devel to melodic-devel April 21, 2018 21:04
@mikepurvis mikepurvis force-pushed the feature/record_udp_nodelay branch from f3f859d to 36c3c11 Compare April 23, 2018 10:47
@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Apr 23, 2018

@ros-pull-request-builder retest this please

@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Apr 23, 2018

The Debian stretch failures are known (#1358), but the subPub failure looks new, and it happened twice in a row. Not obvious to me what's going on with it though:

11:16:43 -- run_tests.py: execute commands
11:16:43   /tmp/catkin_workspace/install_isolated/share/rostest/cmake/../../../bin/rostest --pkgdir=/tmp/catkin_workspace/src/ros_comm/test/test_roscpp --package=test_roscpp --results-filename test_launch_pingpong.xml --results-base-dir /tmp/catkin_workspace/test_results /tmp/catkin_workspace/src/ros_comm/test/test_roscpp/test/launch/pingpong.xml 
11:16:44 ... logging to /home/buildfarm/.ros/log/rostest-056929760d0f-24788.log
11:16:44 [ROSUNIT] Outputting test results to /tmp/catkin_workspace/test_results/test_roscpp/rostest-test_launch_pingpong.xml
11:16:56 [Testcase: testpingpong] ... ok
11:16:56 
11:16:56 [ROSTEST]-----------------------------------------------------------------------
11:16:56 
11:16:56 [test_roscpp.rosunit-pingpong/subPub][FAILURE]----------------------------------
11:16:56 /tmp/catkin_workspace/src/ros_comm/test/test_roscpp/test/src/sub_pub.cpp:126
11:16:56 Failed
11:16:56 --------------------------------------------------------------------------------
11:16:56 
11:16:56 
11:16:56 SUMMARY
11:16:56 �[1;31m * RESULT: FAIL�[0m
11:16:56  * TESTS: 1
11:16:56  * ERRORS: 0
11:16:56 �[1;31m * FAILURES: 1�[0m
11:16:56 
11:16:56 rostest log file is in /home/buildfarm/.ros/log/rostest-056929760d0f-24788.log
11:16:56 -- run_tests.py: verify result "/tmp/catkin_workspace/test_results/test_roscpp/rostest-test_launch_pingpong.xml"
11:16:56 [100%] Built target _run_tests_test_roscpp_rostest_test_launch_pingpong.xml
11:16:56 Scanning dependencies of target _run_tests_test_roscpp_rostest_test_launch_namespaces.xml```

In any case, I can't imagine it's related to this change, since the test has nothing to do with rosbag.

@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Apr 23, 2018

@ros-pull-request-builder retest this please

@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Apr 23, 2018

Looks great, thanks!

@mikepurvis mikepurvis merged commit 4a7a0f3 into ros:melodic-devel Apr 23, 2018
dirk-thomas pushed a commit that referenced this pull request Aug 9, 2018
@alspitz @dirk-thomas
Add TransportHint options --tcpnodelay and --udp (#1295)
8d94003
@dirk-thomas dirk-thomas mentioned this pull request Aug 9, 2018
Merged
dirk-thomas pushed a commit that referenced this pull request Aug 20, 2018
@alspitz @dirk-thomas
Add TransportHint options --tcpnodelay and --udp (#1295)
45a4014
@dirk-thomas dirk-thomas mentioned this pull request Aug 20, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

consider-backport consider-future-release enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alspitz @romainreignier @dirk-thomas @ArekSredzki @mikepurvis