Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Use HTTP/1.1 in XMLRPC Server#1287

Merged
mikepurvis merged 1 commit intoros:lunar-develfrom
magazino:http-1.1
Apr 23, 2018
Merged

Use HTTP/1.1 in XMLRPC Server#1287
mikepurvis merged 1 commit intoros:lunar-develfrom
magazino:http-1.1

Conversation

@mgrrx
Copy link
Copy Markdown
Contributor

@mgrrx mgrrx commented Dec 31, 2017

This PR activates HTTP/1.1 in the XMLRPC Server and fixes the CTRL-C issues that were reported in #371

Setting daemon_threads to True allows the program to terminate.

@dirk-thomas
Copy link
Copy Markdown
Member

Thank you for the patch. This looks really promising! It works for me in the case described in the referenced earlier PR.

@mikepurvis Could you give this patch a try by using it in your deployment for some days?

@mikepurvis
Copy link
Copy Markdown
Member

Looks great, thanks!

@mikepurvis mikepurvis merged commit 5e2b38e into ros:lunar-devel Apr 23, 2018
@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Apr 23, 2018

Oh shoot, wrong target branch.

mikepurvis added a commit that referenced this pull request Apr 23, 2018
This reverts commit 5e2b38e.

This change may be considered for backporting to Lunar at a later time.
mikepurvis pushed a commit that referenced this pull request Apr 23, 2018
@mikepurvis
Copy link
Copy Markdown
Member

Reverted from Lunar, cherry-picked to Melodic as per the linked commits above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants