This repository was archived by the owner on May 31, 2025. It is now read-only.
Fixed incorrect docstrings in rosnode/__init__.py#1278
Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom Jan 29, 2018
ajeetdsouza:lunar-devel
Merged
Fixed incorrect docstrings in rosnode/__init__.py#1278dirk-thomas merged 1 commit intoros:lunar-develfrom ajeetdsouza:lunar-devel
dirk-thomas merged 1 commit intoros:lunar-develfrom
ajeetdsouza:lunar-devel
Conversation
This was referenced Dec 25, 2017
dirk-thomas
reviewed
Jan 5, 2018
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
Please do not mix unrelated changes in a single PR. The title of this PR is about fixing docstring.
Please create separate patches for removing the unnecessary variables.
tools/rosbag/src/rosbag/bag.py
Outdated
| rows.append(('', s)) | ||
|
|
||
| except Exception as ex: | ||
| except: |
Member
There was a problem hiding this comment.
Please do not remove the Exception type. This changes behavior and catches other exception not subclasses from Exception like KeyboardInterrupt.
Same below.
Contributor
Author
|
Sorry! I've reverted the unrelated commits, could you check? |
Member
|
Thank you for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #1254
I closed the previous pull request, since it had conflicts.