add -d option for 'rosmaster' to output LOG_API#1173
add -d option for 'rosmaster' to output LOG_API#1173k-okada wants to merge 1 commit intoros:lunar-develfrom
Conversation
|
The code looks OK to me. Since this is a deep debugging option, it seems to me like it is fine to just have it on rosmaster for now, and then add it to roscore later. @dirk-thomas does that seem reasonable to you? |
How are you currently using the new option? Is that sufficient for you? If not the argument good be passed along the same way. |
| help="override the socket connection timeout (in seconds).", metavar="TIMEOUT") | ||
| parser.add_option("-d", "--debug", | ||
| dest="debug", action="store_true", default=False, | ||
| help="print debug information") |
There was a problem hiding this comment.
I think the help text (and eventually even the option name) should be more specific to what exactly it is doing, namely enabling logging API calls on the master. Maybe the logging level shouldn't be controlled with the same option. That should be configurable already with the rospy logging config file, no?
|
@dirk-thomas > How are you currently using the new option? Is that sufficient for you? If not the argument good be passed along the same way. I'm currently using this option by
I tried to enable this message by rospy logging features, but as far as I understand, it turns out that rosmaster is not 'rosnode', it did not run |
If you think it would be useful please add this to the current patch. If not I am fine to merge this as-is (after you addressed the pending comment about the option name / help text).
I haven't tried it but that could indeed be the case. |
|
Closing in favor of #1180. |
Sometimes, we had seen the CPU Usage of
rosmasteris quit high (more than 50%). Mostly, this because of calling service call multiple times, without usingpersistentor putServiceProxywithin the loop.To find the node calling these services, enabling LOG_API is very helpful, but currently we do not have to modify source code at this moment ( https://github.com/ros/ros_comm/blob/lunar-devel/tools/rosmaster/src/rosmaster/master_api.py#L137 )
I'm not sure if we should pass this option from
roscore->roslaunch->rosmasterlike 08f6bf0#diff-8517d9bf19c03b642c67e5d937dae851