Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

[rospy] Add rospy.logXXX_once#1041

Merged
dirk-thomas merged 3 commits intoros:lunar-develfrom
wkentaro:rospy_logxxx_once
May 24, 2017
Merged

[rospy] Add rospy.logXXX_once#1041
dirk-thomas merged 3 commits intoros:lunar-develfrom
wkentaro:rospy_logxxx_once

Conversation

@wkentaro
Copy link
Copy Markdown
Contributor

@wkentaro wkentaro commented Apr 30, 2017

Following #812

@wkentaro wkentaro changed the title Add rospy.logXXX_once [rospy] Add rospy.logXXX_once Apr 30, 2017
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the once logic should be built on top of the throttle logic. E.g. there is no call Time.now in order to implement once.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented May 24, 2017

Thank you. Can you please add the new logging functions to the wiki page mentioning that they are available as of ROS Lunar and post the link to the diff here.

@dirk-thomas dirk-thomas merged commit ec82978 into ros:lunar-devel May 24, 2017
@wkentaro wkentaro deleted the rospy_logxxx_once branch May 25, 2017 08:47
@wkentaro
Copy link
Copy Markdown
Contributor Author

@dirk-thomas
Copy link
Copy Markdown
Member

Thanks!

sputnick1124 pushed a commit to sputnick1124/ros_comm that referenced this pull request Jul 30, 2017
* Add rospy.logXXX_once

* Stop using logging_throttle in once

* Revert LoggingThrottle
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants