This repository was archived by the owner on May 31, 2025. It is now read-only.
Bugfix to allow loading test cases from name#121
Closed
stonier wants to merge 1 commit intoros:indigo-develfrom
stonier:patch-2
Closed
Bugfix to allow loading test cases from name#121stonier wants to merge 1 commit intoros:indigo-develfrom stonier:patch-2
stonier wants to merge 1 commit intoros:indigo-develfrom
stonier:patch-2
Conversation
This fixes the problem identified in PR #104.
Contributor
Author
|
If this is confirmed, I'll spin up a PR for kinetic and also similar changes over in |
| if issubclass(test, unittest.TestCase): | ||
| suite = unittest.TestLoader().loadTestsFromTestCase(test) | ||
| else: | ||
| if isinstance(test, basestring): |
Member
There was a problem hiding this comment.
This will raise a NameError in Python 3.
Member
|
Thank you for the pull request. I did't notice that the slight change to the logic had that negative side effect. The fix in general looks good beside the comments I added inline. |
Member
|
I created #123 with a much smaller patch. Therefore I will close this as a duplicate. |
dirk-thomas
added a commit
that referenced
this pull request
Sep 16, 2016
stonier
pushed a commit
to stonier/ros
that referenced
this pull request
Sep 19, 2016
This was referenced Sep 19, 2016
dirk-thomas
added a commit
that referenced
this pull request
Mar 1, 2017
dirk-thomas
added a commit
that referenced
this pull request
Mar 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem identified in PR #104. Alternatively could be done by doing the exception handling for
TypeErrorif you wish to handle the majority case (class object) first.