vs2015 doesnt support __has_include, VS2015 and 2017 have both <files…#96
Merged
mikaelarguedas merged 3 commits intoros2from Jan 8, 2018
Merged
vs2015 doesnt support __has_include, VS2015 and 2017 have both <files…#96mikaelarguedas merged 3 commits intoros2from
mikaelarguedas merged 3 commits intoros2from
Conversation
Member
Author
|
…perimental to be namespace-consistent
…ystem> and <experimental/filesystem> but use std::experimental::filesystem in both cases
dda3e12 to
d524d02
Compare
wjwwood
approved these changes
Jan 8, 2018
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, CI (since I messed with the commits):
- Linux
- Linux-aarch64
- macOS
- Windows
Member
Author
wjwwood
added a commit
that referenced
this pull request
Feb 8, 2018
* remove references to plugin_tool from CMakeLists (#93) * move pluginlib in its own folder (port 83 to ros2 branch) (#95) * move pluginlib in its own folder (port 83 to ros2 branch) * fix most linter errors * forward port of #88 Continue loading classes on error * vs2015 doesnt support __has_include, VS2015 and 2017 have both <files… (#96) * windows contains older version of std filesystem * either <experimental/filesystem> or <filesystem> will work ... use experimental to be namespace-consistent * vs2015 doesnt support __has_include, VS2015 and 2017 have both <filesystem> and <experimental/filesystem> but use std::experimental::filesystem in both cases * adjust library search to work on windows, warn about lib prefix (#97)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ystem> and <experimental/filesystem> but use std::experimental::filesystem in both cases
This is a redo of #92 kindly contributed by @bfjelds, I had to open another PR as the folder structure changed and resolving conflicts will be inconvenient.
The rationale for the change and the compiler versions it applies to are documented here.
@wjwwood As the original author of the filesystem detection logic, would you mind giving this a 👀 before I merge it ?