This repository was archived by the owner on May 31, 2025. It is now read-only.
BufferServers uses node name as action namespace#209
Closed
jihoonl wants to merge 1 commit intoros:indigo-develfrom
Closed
BufferServers uses node name as action namespace#209jihoonl wants to merge 1 commit intoros:indigo-develfrom
jihoonl wants to merge 1 commit intoros:indigo-develfrom
Conversation
tfoote
suggested changes
Jul 10, 2017
Member
tfoote
left a comment
There was a problem hiding this comment.
This looks like a general improvement. However this would break the exposed API within the release cycle. To land this change we would need to provide backwards compatibility so we wouldn't break all launch files using this node.
tfoote
added a commit
that referenced
this pull request
May 3, 2018
tfoote
added a commit
that referenced
this pull request
May 3, 2018
tfoote
added a commit
that referenced
this pull request
May 3, 2018
* use nodename as namespace * Update #209 to provide backwards compatibility.
Member
|
replaced by #296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of fixed namespace
tf2_buffer_server.It confused me when I tried to use two tf2 buffer server with different names.