Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fix extra semicolon warning#26

Merged
dirk-thomas merged 1 commit intoros:indigo-develfrom
jpetereit:fix/extra_semicolon
Jun 6, 2016
Merged

Fix extra semicolon warning#26
dirk-thomas merged 1 commit intoros:indigo-develfrom
jpetereit:fix/extra_semicolon

Conversation

@jpetereit
Copy link
Copy Markdown
Contributor

@jpetereit jpetereit commented Jun 6, 2016

When compiling packages that include generated message headers with -Wpedantic, the warning

 warning: extra ‘;’ [-Wpedantic]

is generated by GCC 4.9.3, 5.3.0, and 6.1.1. This is because ROS_DECLARE_ALLINONE_SERIALIZER is defined as:

#define ROS_DECLARE_ALLINONE_SERIALIZER \
  template<typename Stream, typename T> \
  inline static void write(Stream& stream, const T& t) \
  { \
    allInOne<Stream, const T&>(stream, t); \
  } \
  \
  template<typename Stream, typename T> \
  inline static void read(Stream& stream, T& t) \
  { \
    allInOne<Stream, T&>(stream, t); \
  } \
  \
  template<typename T> \
  inline static uint32_t serializedLength(const T& t) \
  { \
    LStream stream; \
    allInOne<LStream, const T&>(stream, t); \
    return stream.getLength(); \
  }

So the ; after inserting ROS_DECLARE_ALLINONE_SERIALIZER is clearly superfluous.

Don't know if there are other places where this needs to be fixed, too. Maybe here?

@dirk-thomas dirk-thomas mentioned this pull request Jun 6, 2016
Merged
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Jun 6, 2016

Thank you for the patch. I applied a similar in ros/ros_comm#817.

@dirk-thomas dirk-thomas merged commit 021ae3e into ros:indigo-devel Jun 6, 2016
@jpetereit
Copy link
Copy Markdown
Contributor Author

jpetereit commented Aug 16, 2016

I'm a little bit confused. The changelog says that the fix went into v0.5.5, released on 2016-06-27. However, the currently distributed ros-jade-gencpp debian package is still version 0.5.3-0trusty-20160110-135827-0800. Is this intentional? Or, more generally: Is there a release matrix somewhere which shows which package version went into which ROS release?

@jpetereit jpetereit deleted the fix/extra_semicolon branch August 16, 2016 08:31
@tfoote
Copy link
Copy Markdown
Member

tfoote commented Aug 16, 2016

Jade has not been synced in a while due to regressions. You can see the current status of packages on the status page: http://repositories.ros.org/status_page/ros_jade_default.html?q=gencpp

There's a regression in MoveIt that needs to be fixed: http://repositories.ros.org/status_page/ros_jade_default.html?q=REGRESSION The latest info on Moveit release planning I think is here: moveit/moveit#22

@meyerj meyerj mentioned this pull request Jan 16, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpetereit @dirk-thomas @tfoote