Use moby/sys/mountinfo#131
Merged
AkihiroSuda merged 1 commit intorootless-containers:masterfrom Mar 17, 2020
Merged
Conversation
Contributor
Author
|
@AkihiroSuda @thaJeztah PTAL |
Contributor
Author
|
Can't figure out why CI fails :( |
AkihiroSuda
reviewed
Mar 17, 2020
pkg/parent/warn.go
Outdated
| logrus.Warn("Failed to parse mountinfo of the root filesystem") | ||
| return | ||
| } | ||
| root = mounts[0] |
Member
There was a problem hiding this comment.
# github.com/rootless-containers/rootlesskit/pkg/parent
src/github.com/rootless-containers/rootlesskit/pkg/parent/warn.go:18:2: undefined: root
src/github.com/rootless-containers/rootlesskit/pkg/parent/warn.go:23:68: undefined: root
src/github.com/rootless-containers/rootlesskit/pkg/parent/warn.go:25:4: undefined: root
Member
|
Thanks, LGTM except the compilation failure |
Drop the implementation forked from runc, use moby/sys/mountinfo. Use SingleEntryFilter as we're only interested in / mount. NOTE we're no longer checking for m.Root == "/", only for the mount point. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
ef06d38 to
221d3be
Compare
Contributor
Author
|
oops, fixed |
AkihiroSuda
approved these changes
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this is a followup to #122)
Drop the implementation forked from runc, use moby/sys/mountinfo.
Use SingleEntryFilter as we're only interested in / mount.
NOTE we're no longer checking for m.Root == "/", only for
the mount point.