print warning when preconditions are not satisfied + release v0.9.1#122
Merged
AkihiroSuda merged 3 commits intorootless-containers:masterfrom Mar 7, 2020
Merged
print warning when preconditions are not satisfied + release v0.9.1#122AkihiroSuda merged 3 commits intorootless-containers:masterfrom
AkihiroSuda merged 3 commits intorootless-containers:masterfrom
Conversation
Member
AkihiroSuda
commented
Mar 7, 2020
- print warning when unsupported propagation was specified (Suggested in rootless: launch rootlesskit with --propagation=rslave moby/moby#40635 (comment) , CC @thaJeztah @cpuguy83)
- print sysctl warnings
- print warning if running as root
thaJeztah
approved these changes
Mar 7, 2020
Contributor
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
left some comments inline
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Mar 9, 2020
Notable change: RootlessKit now prints warnings when the sysctl preconditions are not satisfied. rootless-containers/rootlesskit#122 https://github.com/rootless-containers/rootlesskit/releases Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.