Skip to content

[GSOC][TMVA][SOFIE] Some error messages and spelling mistakes fixed related to operators#10435

Merged
lmoneta merged 2 commits into
root-project:masterfrom
Neel-Shah-29:Fix-operators
Jun 30, 2022
Merged

[GSOC][TMVA][SOFIE] Some error messages and spelling mistakes fixed related to operators#10435
lmoneta merged 2 commits into
root-project:masterfrom
Neel-Shah-29:Fix-operators

Conversation

@Neel-Shah-29

@Neel-Shah-29 Neel-Shah-29 commented Apr 21, 2022 •
edited by ferdymercury
Loading

Copy link
Copy Markdown
Contributor

This Pull request: fixes some error messages and spelling mistakes in operators

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot

phsft-bot commented Apr 21, 2022

Copy link
Copy Markdown

Can one of the admins verify this patch?

@ferdymercury ferdymercury changed the title Some error messages and spelling mistakes fixed related to operaters Some error messages and spelling mistakes fixed related to operators Apr 25, 2022
lmoneta
lmoneta requested changes Jun 1, 2022
View reviewed changes

@lmoneta lmoneta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the spelling fix.
I have just a small request on fixing the indentation to the ROperator_BatchNormalization.hxx file

Comment thread tmva/sofie/inc/TMVA/ROperator_BatchNormalization.hxx Outdated
@lmoneta

lmoneta commented Jun 1, 2022

Copy link
Copy Markdown
Member

You can look also at the result of clang-format that will be available after I trigger a build

@lmoneta

lmoneta commented Jun 1, 2022

Copy link
Copy Markdown
Member

@phsft-bot build

@phsft-bot

phsft-bot commented Jun 1, 2022

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

phsft-bot commented Jun 1, 2022

Copy link
Copy Markdown

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@Neel-Shah-29 Neel-Shah-29 requested a review from lmoneta June 2, 2022 13:10
lmoneta
lmoneta approved these changes Jun 29, 2022
View reviewed changes

@lmoneta lmoneta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmoneta

lmoneta commented Jun 29, 2022

Copy link
Copy Markdown
Member

@phsft-bot build just on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On

@phsft-bot

phsft-bot commented Jun 29, 2022

Copy link
Copy Markdown

Starting build on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On
How to customize builds

@phsft-bot

phsft-bot commented Jun 29, 2022

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-06-29T20:32:47.483Z] FAILED: lib/modules.idx

@lmoneta lmoneta merged commit 4e0ef33 into root-project:master Jun 30, 2022
@Neel-Shah-29 Neel-Shah-29 deleted the Fix-operators branch June 30, 2022 07:53
vepadulano pushed a commit to vepadulano/root that referenced this pull request Jul 20, 2022
@Neel-Shah-29 @vepadulano
Some error messages and spelling mistakes fixed related to operators (r…
fd3b123 
…oot-project#10435)

* Some error messages and spelling mistakes fixed related to operaters

* Update the indentation of BatchNormalization.hxx

Co-authored-by: Neel Shah <neelshah29042002.com>
j-mathe pushed a commit to j-mathe/root that referenced this pull request Jul 26, 2022
@Neel-Shah-29 @j-mathe
Some error messages and spelling mistakes fixed related to operators (r…
16fa028 
…oot-project#10435)

* Some error messages and spelling mistakes fixed related to operaters

* Update the indentation of BatchNormalization.hxx

Co-authored-by: Neel Shah <neelshah29042002.com>
@Neel-Shah-29 Neel-Shah-29 changed the title Some error messages and spelling mistakes fixed related to operators [GSOC][TMVA][SOFIE] Some error messages and spelling mistakes fixed related to operators Jul 2, 2023
@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:03:41.138Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:03:46.116Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:03:46.185Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:03:48.375Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:03:49.310Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on mac11/noimt.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:03:53.681Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot

phsft-bot commented Jul 2, 2023

Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-07-02T14:05:50.018Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmoneta lmoneta lmoneta approved these changes

@sitongan sitongan Awaiting requested review from sitongan

Assignees

@lmoneta lmoneta

Labels

in:Documentation in:TMVA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neel-Shah-29 @phsft-bot @lmoneta @ferdymercury