ceph: add permissions to rook-ceph-mgr role for osd removal in rook orchestator#8568
Merged
travisn merged 1 commit intorook:masterfrom Aug 19, 2021
Merged
Conversation
travisn
requested changes
Aug 19, 2021
| - deployments/scale | ||
| verbs: | ||
| - patch | ||
| - apiGroups: |
Member
There was a problem hiding this comment.
It seems fine to combine this with the previous one so that deployments/scale and deployments can have both patch and delete access.
This commit adds permissions to the rook-ceph-mgr role to delete PVCs and deployments and patch deployment scale to remove OSDs using `ceph orch osd rm` in the rook orchestrator. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
06bcde8 to
331e066
Compare
travisn
approved these changes
Aug 19, 2021
mergify bot
added a commit
that referenced
this pull request
Aug 19, 2021
ceph: add permissions to rook-ceph-mgr role for osd removal in rook orchestator (backport #8568)
parth-gr
pushed a commit
to parth-gr/rook
that referenced
this pull request
Aug 20, 2021
…role ceph: add permissions to rook-ceph-mgr role for osd removal in rook orchestator Signed-off-by: parth-gr <paarora@redhat.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This commit adds permissions to the rook-ceph-mgr role to delete PVCs and deployments and patch deployment scale
to remove OSDs using
ceph orch osd rmin the rook orchestrator.Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.