Fixes #3905

Summary: Remove Unused Snapshot Config Knobs

Issue

GitHub Issue #3905: Remove unused/unsupported snapshot configuration knobs that add confusion.

Changes Made

1. Removed Config Fields from SnapshotBuilderConfig

File: crates/rooch-pruner/src/state_prune/config.rs

Removed fields:

• workers - Number of parallel workers (unused in snapshot building)
• enable_progress_tracking - Progress tracking was always enabled regardless of this setting
• max_traversal_time_hours - Maximum traversal time limit (not enforced)
• deduplication_strategy - Only RocksDB strategy is actually implemented
• enable_bloom_filter - Legacy field replaced by deduplication_strategy
• bloom_filter_fp_rate - Bloom filter false positive rate (unused)
• deduplication_batch_size - Separate batch size for deduplication (unused)

Removed methods:

• DeduplicationStrategy enum (removed entirely as only RocksDB is used)
• get_deduplication_batch_size() method

Updated methods:

• validate() - Removed validation for deleted fields
• should_use_adaptive_batching() - Simplified to only check enable_adaptive_batching
• from_state_prune_config() - Removed mapping of deleted fields

2. Removed Config Fields from SnapshotConfig

File: crates/rooch-config/src/state_prune.rs

Removed fields:

• enable_progress_tracking - Unused in snapshot operations
• max_traversal_time_hours - Not enforced in snapshot creation

3. Updated CLI Command

File: crates/rooch/src/commands/db/commands/state_prune/snapshot.rs

Removed:

• --workers CLI argument
• Import of DeduplicationStrategy
• Hardcoded values for removed config fields

4. Updated Tests

Rust Tests:

• crates/rooch-pruner/tests/state_prune_tests.rs - Removed assertions for deleted config fields
• crates/rooch-pruner/src/tests/scalable_dedup_test.rs - Updated test configs to remove deleted fields

TypeScript Tests:

• sdk/typescript/rooch-pruner-e2e/src/case/state-prune.spec.ts - Removed:
  • --workers CLI flag usage (2 locations)
  • Removed config fields in test configuration objects:
    • enable_progress_tracking
    • workers
    • max_traversal_time_hours
    • enable_bloom_filter
    • bloom_filter_fp_rate

Verification

Build Status

• cargo check --package rooch-pruner - PASSED
• cargo check --package rooch-config - PASSED
• cargo check --package rooch - PASSED

Test Results

• cargo test --package rooch-pruner --lib state_prune - 12 tests passed
• cargo test --package rooch-pruner --test state_prune_tests - 17 tests passed

Note: One unrelated test (test_batch_size_performance) failed due to a pre-existing memory alignment issue in bloom_filter.rs, not related to these changes.

Remaining Config Fields

SnapshotBuilderConfig (after changes)

pub struct SnapshotBuilderConfig {
    pub batch_size: usize,              // Batch size for processing nodes
    pub memory_limit: u64,              // Memory limit in bytes
    pub progress_interval_seconds: u64,  // Progress reporting interval
    pub enable_resume: bool,            // Enable resume functionality
    pub enable_adaptive_batching: bool, // Enable adaptive batch sizing
    pub memory_pressure_threshold: f64, // Memory pressure threshold
}

SnapshotConfig (after changes)

pub struct SnapshotConfig {
    pub default_output_dir: PathBuf,        // Default output directory
    pub max_batch_size: usize,              // Maximum batch size
    pub progress_interval_seconds: u64,     // Progress reporting interval
    pub enable_resume: bool,                // Enable resume functionality
}

Impact

• Snapshot builder behavior is unchanged for the default path
• Only RocksDB-based deduplication is now supported (the only working implementation)
• Configuration is simpler and less confusing for users
• All removed fields were either unused or had no effect on behavior