Remove obsolete check_refcount command from archived runtime pruning system#3852
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Co-authored-by: jolestar <77268+jolestar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove obsolete check-refcount command from runtime pruning system
Remove obsolete check_refcount command from archived runtime pruning system
Dec 8, 2025
jolestar
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete check-refcount command, a diagnostic tool for the archived runtime pruning system that has been superseded by offline garbage collection. The command compared reference counts across various database column families to identify inconsistencies, but this functionality is no longer relevant as the runtime pruner has been disabled and the refcount tracking system is non-functional in the current offline GC architecture.
Key Changes:
- Deleted the entire
check_refcount.rscommand implementation (198 lines) - Removed all registrations and references to the command from the DB command infrastructure
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/rooch/src/commands/db/commands/check_refcount.rs |
Complete deletion of the obsolete refcount diagnostic command implementation |
crates/rooch/src/commands/db/mod.rs |
Removed import, enum variant, and match arm for CheckRefcountCommand |
crates/rooch/src/commands/db/commands/mod.rs |
Removed module declaration for check_refcount |
jolestar
approved these changes
Dec 8, 2025
jolestar
added a commit
that referenced
this pull request
Dec 8, 2025
Re-implement the check_refcount command that was removed in commit #3852 to provide database consistency checking for reference counts used by the garbage collection system. This command helps identify inconsistencies between actual node presence and reference counts, providing health assessment and detailed reporting for database maintenance operations. Features: - Comprehensive reference count consistency checking - JSON and table output formats - Configurable limits and batch processing - Health assessment and issue reporting - Support for error-only reporting mode Fixes #3850 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
check_refcountcommand, a diagnostic tool for the archived runtime pruning system that has been superseded by offline GC.Changes
crates/rooch/src/commands/db/commands/check_refcount.rs(198 lines)db/commands/mod.rsanddb/mod.rsThe command compared
state_node,node_refcount, andsmt_stalecolumn families to identify refcount inconsistencies. Runtime pruning's refcount system is non-functional in the current offline GC architecture - functions likeinc_node_refcountanddec_node_refcountare never called.No functional impact. The command accessed relics of the old architecture with no integration to current systems.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https /home/REDACTED/.rustup/toolchains/1.82.0-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libobject-a25e7f31e2204719.rlib /home/REDACTED/.rustup/toolchains/1.82.0-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libmemchr-1f1858edbb50ccb5.rlib /home/REDACTED/.rustup/toolchains/1.82.0-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libaddr2line-1319b75889377807.rlib /home/REDACTED/.rustup/toolchains/1.82.0-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libgimli-c9972d847170eb93.rlib /home/REDACTED/.rustup/toolchains/1.82.0-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/librustc_demangle-0868a75d0b80f801.rlib ipt_build-81472a11ec80f9bf.build_script_build.34e35a76a1578e34-cgu.0.rcgu.o ipt_build-81472a11ec80f9bf.build_script_build.34e35a76a1578e34-cgu.1.rcgu.o ipt_build-81472a11ec80f9bf.build_script_build.34e35a76a1578e34-cgu.2.rcgu.o ipt_build-81472a11ec80f9bf.build_script_build.34e35a76a1578e34-cgu.3.rcgu.o ipt_build-81472a11ec80f9bf.cj2ba1zxmi56yjp5qyclbbif0.rcgu.o /home/REDACTED/.rustup/toolchains/1.82.0-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libunwind-d2b4a3bc57672e2c.rlib 64-u�� 64-REDACTED-linux-gnu/lib/libstd-22be60875a4ac8d7.rlib 64-REDACTED-linux-gnu/lib/libpanic_unwind-4b832a03827ff95e.rlib 64-REDACTED-linux-gnu/lib/libobject-a25e7f31e2204719.rlib 64-REDACTED-linux-gnu/lib/libmemchr-1f1858edbb50ccb5.rlib 64-REDACTED-linux-gnu/lib/libaddr2line-1319b75889377807.rlib 64-REDACTED-linux-gnu/lib/libgimli-c9972d847170eb93.rlib 64-REDACTED-linux-gnu/lib/librustc_demangle-0868a75d0b80f801.rlib(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.