Skip to content

core: don't add basefee to treasury in system transaction in tracing#24

Merged
huyngopt1994 merged 1 commit intoronin-chain:masterfrom
minh-bq:fix/treasury-balance
Feb 27, 2025
Merged

core: don't add basefee to treasury in system transaction in tracing#24
huyngopt1994 merged 1 commit intoronin-chain:masterfrom
minh-bq:fix/treasury-balance

Conversation

@minh-bq
Copy link
Copy Markdown
Contributor

@minh-bq minh-bq commented Feb 26, 2025

As the system transaction does not follow the basefee rule, make this behavior consistent in tracing path. This commit also refactors the code the skip the whole transaction's epilogue for system transaction in tracing.

As the system transaction does not follow the basefee rule, make this behavior
consistent in tracing path. This commit also refactors the code the skip the
whole transaction's epilogue for system transaction in tracing.
Copy link
Copy Markdown
Contributor

@huyngopt1994 huyngopt1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM

@huyngopt1994 huyngopt1994 merged commit 0ce57fd into ronin-chain:master Feb 27, 2025
huyngopt1994 pushed a commit that referenced this pull request Feb 27, 2025
…24)

As the system transaction does not follow the basefee rule, make this behavior
consistent in tracing path. This commit also refactors the code the skip the
whole transaction's epilogue for system transaction in tracing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants