Skip to content

add Map::retain method#460

Merged
juntyr merged 1 commit into
ron-rs:masterfrom
marcospb19:add-map-retain-method
Jun 28, 2023
Merged

add Map::retain method#460
juntyr merged 1 commit into
ron-rs:masterfrom
marcospb19:add-map-retain-method

Conversation

@marcospb19

@marcospb19 marcospb19 commented Jun 28, 2023

Copy link
Copy Markdown
Contributor
  • I've included my change in CHANGELOG.md

juntyr
juntyr reviewed Jun 28, 2023
View reviewed changes
Comment thread src/value/mod.rs Outdated
juntyr
juntyr reviewed Jun 28, 2023
View reviewed changes
Comment thread CHANGELOG.md Outdated
@codecov-commenter

codecov-commenter commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.29%. Comparing base (8fa9995) to head (2b247a6).
⚠️ Report is 94 commits behind head on master.

Files with missing lines Patch % Lines
src/value/mod.rs 0.00% 9 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   85.65%   85.29%   -0.37%     
==========================================
  Files          61       61              
  Lines        7760     7793      +33     
==========================================
  Hits         6647     6647              
- Misses       1113     1146      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

juntyr
juntyr requested changes Jun 28, 2023
View reviewed changes

@juntyr juntyr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggested changes applied.

Thank you @marcospb19 for your contribution!

@marcospb19 marcospb19 force-pushed the add-map-retain-method branch from b4db797 to 2b247a6 Compare June 28, 2023 07:03
@marcospb19

marcospb19 commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Force-pushed accordingly, thanks for the great review :D .

juntyr
juntyr approved these changes Jun 28, 2023
View reviewed changes

@juntyr juntyr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr juntyr merged commit 82536cf into ron-rs:master Jun 28, 2023
@marcospb19 marcospb19 deleted the add-map-retain-method branch June 28, 2023 07:40
juntyr pushed a commit to juntyr/ron that referenced this pull request Aug 15, 2023
@marcospb19 @juntyr
Add the Map::retain method (ron-rs#460)
5a63b66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juntyr juntyr juntyr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcospb19 @codecov-commenter @juntyr