depend on serde_derive separately for more compilation parallelism#441
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 84.52% 86.73% +2.20%
==========================================
Files 59 59
Lines 7470 7280 -190
==========================================
Hits 6314 6314
+ Misses 1156 966 -190
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
|
I’ll review later tonight after dinner |
juntyr
pushed a commit
to juntyr/ron
that referenced
this pull request
Aug 15, 2023
…on-rs#441) * depend on serde_derive separately for more compilation parallelism * add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdIf no crate enables the
derivefeature ofserde, thenserdeandserde_derivecan compile in parallel, and anything depending only onserdecan compile whileserde_deriveis not yet done.This can save up to 5 seconds of compilation, depending on whether this helps the critical chain and if no other crate enables the feature.