Skip to content

Fix trailing comma parsing in tuples and Some#412

Merged
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:410-trailing-comma
Oct 4, 2022
Merged

Fix trailing comma parsing in tuples and Some#412
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:410-trailing-comma

Conversation

@juntyr

@juntyr juntyr commented Oct 4, 2022

Copy link
Copy Markdown
Member

Fixes #410 trailing commas in all Some, tuples, structs, lists, maps, and enums.

  • after using CommaSeparated we only need to skip whitespace, not an extra comma
  • after newtype structs or variants we need to explicitly allow trailing commas
  • I've included my change in CHANGELOG.md

@codecov-commenter

codecov-commenter commented Oct 4, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.86%. Comparing base (298f918) to head (516a14c).
⚠️ Report is 115 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   79.81%   88.86%   +9.04%     
==========================================
  Files          54       55       +1     
  Lines        7080     6437     -643     
==========================================
+ Hits         5651     5720      +69     
+ Misses       1429      717     -712     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juntyr juntyr merged commit 7a68926 into ron-rs:master Oct 4, 2022
@juntyr juntyr deleted the 410-trailing-comma branch October 4, 2022 06:11
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trailing comma in Some()

2 participants