Skip to content

Fix #277 and #405 with Value::Map IntoIter and extraneous item check for Value::Seq#406

Merged
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:405-value-seq-map
Aug 26, 2022
Merged

Fix #277 and #405 with Value::Map IntoIter and extraneous item check for Value::Seq#406
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:405-value-seq-map

Conversation

@juntyr

@juntyr juntyr commented Aug 26, 2022

Copy link
Copy Markdown
Member

Fixes #277
Fixes #405

  • I've included my change in CHANGELOG.md

…eous item check for `Value::Seq`
@codecov-commenter

codecov-commenter commented Aug 26, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 69.76744% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.52%. Comparing base (fc6d4b8) to head (bee1974).
⚠️ Report is 118 commits behind head on master.

Files with missing lines Patch % Lines
src/value.rs 60.71% 22 Missing ⚠️
tests/value.rs 86.66% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   80.46%   79.52%   -0.94%     
==========================================
  Files          50       50              
  Lines        6287     6419     +132     
==========================================
+ Hits         5059     5105      +46     
- Misses       1228     1314      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juntyr juntyr merged commit 21833a8 into ron-rs:master Aug 26, 2022
@juntyr juntyr deleted the 405-value-seq-map branch August 26, 2022 08:29
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deserialising array from Value allows extraneous values Missing IntoIterator trait impl for Map

2 participants