Fixed raw struct name identifier parsing#402
Merged
Merged
Conversation
torkleyy
reviewed
Aug 21, 2022
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 79.52% 78.74% -0.79%
==========================================
Files 50 51 +1
Lines 6419 6737 +318
==========================================
+ Hits 5105 5305 +200
- Misses 1314 1432 +118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@torkleyy Can I merge this PR? |
juntyr
added a commit
to juntyr/ron
that referenced
this pull request
Aug 15, 2023
* Fixed raw struct name identifier parsing * Added more tests, raw identifier suggestion error, and invalid identifier error formatting * Even more empty identifier tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401
@torkleyy Deserialisation currently does NOT validate expected identifiers, so one could get an error saying
found "World" but expected "Hello World"which has absolutely no user-side fix if you don't control the data structure you're deserialising into. I could specialise the error messages to add a note if an invalid identifier was expected, but that might clutter the code base.CHANGELOG.md