Skip to content

Expected bytes error and import cleanup#400

Merged
juntyr merged 2 commits into
ron-rs:masterfrom
juntyr:expected-bytes-error
Aug 16, 2022
Merged

Expected bytes error and import cleanup#400
juntyr merged 2 commits into
ron-rs:masterfrom
juntyr:expected-bytes-error

Conversation

@juntyr

@juntyr juntyr commented Aug 16, 2022

Copy link
Copy Markdown
Member

This cleanup PR includes

  • a small change to the error message for the unexpected bytes error to print the bytesrting with base64, since that's how it shows up in the ron
  • reformatting of all import statements (using the unstable imports_granularity = "Crate" and group_imports = "StdExternalCrate" options)

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter

codecov-commenter commented Aug 16, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.31%. Comparing base (4089034) to head (6039cec).
⚠️ Report is 120 commits behind head on master.

Files with missing lines Patch % Lines
src/de/value.rs 0.00% 2 Missing ⚠️
src/error.rs 33.33% 2 Missing ⚠️
src/ser/tests.rs 0.00% 1 Missing ⚠️
src/value.rs 0.00% 1 Missing ⚠️
tests/147_empty_sets_serialisation.rs 0.00% 1 Missing ⚠️
tests/depth_limit.rs 0.00% 1 Missing ⚠️
tests/extensions.rs 0.00% 1 Missing ⚠️
tests/numbers.rs 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   86.55%   80.31%   -6.25%     
==========================================
  Files          49       49              
  Lines        5803     6247     +444     
==========================================
- Hits         5023     5017       -6     
- Misses        780     1230     +450     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juntyr

juntyr commented Aug 16, 2022

Copy link
Copy Markdown
Member Author

The codecov changes seem to be spurious since they only affect use statements.

@juntyr juntyr merged commit 75ac75e into ron-rs:master Aug 16, 2022
@juntyr juntyr deleted the expected-bytes-error branch August 16, 2022 18:13
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
* Format expected bytes error with base64 as in ron

* Reformat imports to be consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants