Skip to content

Fix \0 in string on nightly + enable weekly CI#373

Merged
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:nul-in-string-nightly
Apr 1, 2022
Merged

Fix \0 in string on nightly + enable weekly CI#373
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:nul-in-string-nightly

Conversation

@juntyr

@juntyr juntyr commented Mar 31, 2022

Copy link
Copy Markdown
Member

Add the \0 special case to escape character handling to fix parsing it on nightly tests.

Also enables CI tests on every Sunday at midnight to catch nightly failures in quiet times.

* [ ] I've included my change in CHANGELOG.md

@juntyr

juntyr commented Mar 31, 2022

Copy link
Copy Markdown
Member Author

?r @torkleyy This should be a very simple fix - I will merge the PR tonight to unblock #372 unless there is a need for a change

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #373 (2089e49) into master (4d16313) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   89.63%   89.64%   +0.01%     
==========================================
  Files          48       48              
  Lines        5219     5226       +7     
==========================================
+ Hits         4678     4685       +7     
  Misses        541      541              
Impacted Files Coverage Δ
src/parse.rs 93.76% <100.00%> (+0.01%) ⬆️
tests/escape.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d16313...2089e49. Read the comment docs.

@juntyr juntyr self-assigned this Mar 31, 2022
@juntyr juntyr merged commit 706162d into ron-rs:master Apr 1, 2022
@juntyr juntyr deleted the nul-in-string-nightly branch April 1, 2022 04:35
Comment thread .github/workflows/ci.yaml
- master
- 'v*.*'
schedule:
- cron: '0 0 * * 0'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow such fancy!

torkleyy pushed a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants