Skip to content

Add code coverage CI step#366

Merged
juntyr merged 3 commits into
ron-rs:masterfrom
juntyr:codecov
Feb 24, 2022
Merged

Add code coverage CI step#366
juntyr merged 3 commits into
ron-rs:masterfrom
juntyr:codecov

Conversation

@juntyr

@juntyr juntyr commented Feb 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #176

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter

codecov-commenter commented Feb 20, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@e542eff). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #366   +/-   ##
=========================================
  Coverage          ?   88.96%           
=========================================
  Files             ?       46           
  Lines             ?     5056           
  Branches          ?        0           
=========================================
  Hits              ?     4498           
  Misses            ?      558           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e542eff...54af3a6. Read the comment docs.

@juntyr juntyr marked this pull request as ready for review February 20, 2022 09:49
@juntyr

juntyr commented Feb 20, 2022

Copy link
Copy Markdown
Member Author

@kvark @torkleyy I'm hoping that just adding the CI step and badge should just work. Ideally, we wouldn't need to reinstall grcov on every CI run, but the actions-rs/install action that could solve this still has security issues - potentially this might become an incremental improvement later on. I've added GRCOV_EXCL_LINE, GRCOV_EXCL_START, and GRCOV_EXCL_STOP markers so we can exclude sections from coverage analysis.

@juntyr

juntyr commented Feb 20, 2022

Copy link
Copy Markdown
Member Author

If we don't find any issues with this PR, I'll merge it by February 28th.

@juntyr juntyr self-assigned this Feb 20, 2022
torkleyy
torkleyy approved these changes Feb 24, 2022
View reviewed changes

@torkleyy torkleyy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

Comment thread .github/workflows/ci.yaml Outdated
torkleyy
torkleyy approved these changes Feb 24, 2022
View reviewed changes

@torkleyy torkleyy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@juntyr juntyr merged commit 708a182 into ron-rs:master Feb 24, 2022
@juntyr juntyr deleted the codecov branch February 24, 2022 12:04
torkleyy pushed a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
@juntyr @torkleyy
Add code coverage CI step (ron-rs#366)
b62b0c0 
* Add code coverage CI step

* Added codecov badge to README

* Exclude examples from codecov collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torkleyy torkleyy torkleyy approved these changes

Assignees

@juntyr juntyr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add code coverage badge

3 participants

@juntyr @codecov-commenter @torkleyy