Skip to content

Add struct name mismatch error + better error messages#354

Merged
torkleyy merged 2 commits into
ron-rs:masterfrom
juntyr:better-errors
Dec 27, 2021
Merged

Add struct name mismatch error + better error messages#354
torkleyy merged 2 commits into
ron-rs:masterfrom
juntyr:better-errors

Conversation

@juntyr

@juntyr juntyr commented Dec 26, 2021

Copy link
Copy Markdown
Member

Fixes #301 by adding a new ExpectedStructName error variant when a struct name is found but doesn't match the expected one. This PR also improves the error messages to be clearer about what is expected in the RON string, not how it is implemented (e.g. Expected opening ( instead of Expected struct)

  • I've included my change in CHANGELOG.md

@juntyr

juntyr commented Dec 26, 2021

Copy link
Copy Markdown
Member Author

?r @torkleyy

@torkleyy torkleyy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@torkleyy torkleyy merged commit 07f8d96 into ron-rs:master Dec 27, 2021
@juntyr juntyr deleted the better-errors branch January 28, 2022 09:48
torkleyy added a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
Add struct name mismatch error + better error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhelpful error message when struct name doesn't match

2 participants