Skip to content

Fix #265 with better missing comma detection#353

Merged
juntyr merged 2 commits into
ron-rs:masterfrom
juntyr:265-comma-error
Dec 25, 2021
Merged

Fix #265 with better missing comma detection#353
juntyr merged 2 commits into
ron-rs:masterfrom
juntyr:265-comma-error

Conversation

@juntyr

@juntyr juntyr commented Dec 25, 2021

Copy link
Copy Markdown
Member

Fix #265 by better dealing with missing comma in CommaSeparated so that an ExpectedComma error can be reported.

  • I've included my change in CHANGELOG.md

@juntyr

juntyr commented Dec 25, 2021

Copy link
Copy Markdown
Member Author

?r @torkleyy This should be a quick fix as it really just detects the error earlier without needing any extra information

@juntyr juntyr marked this pull request as ready for review December 25, 2021 08:59

@torkleyy torkleyy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@juntyr juntyr merged commit 4e9e4fd into ron-rs:master Dec 25, 2021
@juntyr juntyr deleted the 265-comma-error branch December 25, 2021 09:25
torkleyy pushed a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing commas produce unhelpful errors with col/line 0

2 participants