Guard u128 and i128 behind optional integer128 feature#351
Merged
Conversation
Member
Author
|
@torkleyy @kvark @caiiiycuk I've started the implementation to add an |
kvark
reviewed
Dec 20, 2021
kvark
left a comment
Collaborator
There was a problem hiding this comment.
Thank you!
I believe the direction is sound
kvark
approved these changes
Dec 21, 2021
u128 and i128 behind on-by-default integer128 featureu128 and i128 behind optional integer128 feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
integer128feature that guards the usage ofi128andu128. Therefore, any library usingserdewith either of these types should now enable the feature. This PR is heavily inspired by #304.CHANGELOG.md