make u128, i128 behind feature integer128#304
Closed
clouds56 wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Sorry for getting late here. A feature has costs in that it needs to be tested, and as features grow the testing becomes more difficult. So generally we'd want to avoid features where possible. |
Contributor
Author
|
Yes, we could do this just like what it does in serde. |
Collaborator
|
Is this particular thing difficult to test on CI? I.e. does github CI have any platform targets that don't have 128-bit scalars? |
|
Issue has had no activity in the last 60 days and is going to be closed in 7 days if no further activity occurs |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some target that not support u128 like emscripten