Skip to content

make u128, i128 behind feature integer128#304

Closed
clouds56 wants to merge 2 commits into
ron-rs:masterfrom
clouds56:integer128
Closed

make u128, i128 behind feature integer128#304
clouds56 wants to merge 2 commits into
ron-rs:masterfrom
clouds56:integer128

Conversation

@clouds56

Copy link
Copy Markdown
Contributor

for some target that not support u128 like emscripten

@kvark

kvark commented May 31, 2021

Copy link
Copy Markdown
Collaborator

Sorry for getting late here. A feature has costs in that it needs to be tested, and as features grow the testing becomes more difficult. So generally we'd want to avoid features where possible.
Here, if some platforms don't support 128-bit integers, could we instead detect them via cfg flags?

@clouds56

clouds56 commented Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

Yes, we could do this just like what it does in serde.
But I don't think it would make test easier since we have to install another compiler for test.

@kvark

kvark commented Jun 1, 2021

Copy link
Copy Markdown
Collaborator

Is this particular thing difficult to test on CI? I.e. does github CI have any platform targets that don't have 128-bit scalars?

@github-actions

Copy link
Copy Markdown

Issue has had no activity in the last 60 days and is going to be closed in 7 days if no further activity occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants