Skip to content

Fix #207 with unit test#346

Merged
torkleyy merged 1 commit into
ron-rs:masterfrom
juntyr:adjacently-tagged-enum
Dec 3, 2021
Merged

Fix #207 with unit test#346
torkleyy merged 1 commit into
ron-rs:masterfrom
juntyr:adjacently-tagged-enum

Conversation

@juntyr

@juntyr juntyr commented Dec 3, 2021

Copy link
Copy Markdown
Member

Ensure that #207 has been fixed by adding the given failing case as a unit test

  • [ ] I've included my change in CHANGELOG.md

@juntyr juntyr requested a review from torkleyy December 3, 2021 10:40
@juntyr

juntyr commented Dec 3, 2021

Copy link
Copy Markdown
Member Author

@torkleyy I just stumbled across this issue and wanted to see if it still applies. Given the provided failing case in the report, it now seems to work. If you're happy with the unit test that will make sure this doesn't break, you can merge it :)

@torkleyy torkleyy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@torkleyy torkleyy merged commit d191d8e into ron-rs:master Dec 3, 2021
@juntyr juntyr deleted the adjacently-tagged-enum branch December 18, 2021 10:50
torkleyy added a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants