Added improved ExpectedStruct error message#342
Merged
Conversation
Member
Author
|
@torkleyy In relation to #301 (comment) I did some small experimentation to ever so slightly improve the error message from |
torkleyy
reviewed
Nov 30, 2021
torkleyy
left a comment
Member
There was a problem hiding this comment.
Great quality of life improvement! Can we always include the struct name in the error?
Member
Author
Ok, I'll add the Changelog entry and merge it later today :) |
81f5087 to
5a7fbeb
Compare
Member
Author
|
@torkleyy Ready to merge? |
torkleyy
pushed a commit
to torkleyy/ron
that referenced
this pull request
Jun 6, 2022
Added improved `ExpectedStruct` error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the error messages for
ExpectedStruct(nowExpectedNamedStruct),NoSuchExtension, andUnexpectedByteby including the erroneous identifier in the message. This small change should help with #301.CHANGELOG.md