fix: use the original class name in the class body#4827
Merged
lukastaegert merged 7 commits intorollup:masterfrom Feb 1, 2023
Merged
fix: use the original class name in the class body#4827lukastaegert merged 7 commits intorollup:masterfrom
lukastaegert merged 7 commits intorollup:masterfrom
Conversation
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
72d77a6 to
99d8310
Compare
Codecov Report
@@ Coverage Diff @@
## master #4827 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 219 219
Lines 7834 7835 +1
Branches 2168 2168
=======================================
+ Hits 7756 7757 +1
Misses 26 26
Partials 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install TrickyPi/rollup#fix/static-block-classor load it into the REPL: |
Member
|
For the failing tests, note that you can add a parameter module.exports = {
description: 'use class name instead of renderName in static block',
minNodeVersion: 16
}; |
Member
Author
Ok, Thanks! |
c24c02a to
f8d67fc
Compare
lukastaegert
approved these changes
Feb 1, 2023
lukastaegert
pushed a commit
that referenced
this pull request
Feb 1, 2023
* fix: add useOriginalName option * test: add test * test: remove solo * test: set minNodeVersion * refactor: override useOriginalName in ClassDeclaration * test: add more cases * test: tweak description
Collaborator
|
This PR has been released as part of rollup@3.12.1. You can test it via |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4811
Description
The
Variablerenders a proper name according to the return of theuseOriginalNamefunction.