[v3.0] Change default for systemNullSetters#4649
Merged
lukastaegert merged 1 commit intorelease-3.0.0from Oct 7, 2022
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#rollup-3-system-null-settersor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## release-3.0.0 #4649 +/- ##
==============================================
Coverage 98.97% 98.97%
==============================================
Files 213 213
Lines 7481 7481
Branches 2112 2112
==============================================
Hits 7404 7404
Misses 23 23
Partials 54 54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via |
lukastaegert
added a commit
that referenced
this pull request
Oct 11, 2022
Collaborator
|
This PR has been released as part of rollup@3.0.0. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
One last change I stumbled upon when looking through the options. The
systemNullSetterswas introduced to generate slightly simplified output for SystemJS >= 6.3.3. I reckon it makes sense to enable it by default now.