Skip to content

[v3.0] Improve asset emission performance#4644

Merged
lukastaegert merged 1 commit intorelease-3.0.0from
improve-asset-emission-performance
Sep 23, 2022
Merged

[v3.0] Improve asset emission performance#4644
lukastaegert merged 1 commit intorelease-3.0.0from
improve-asset-emission-performance

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Sep 23, 2022 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Breaking change: typed array/Buffer assets are no longer deduplicated.

This changes the asset emission logic in two ways:

  • To deduplicate assets with string sources, we build a reverse map source -> fileName for O(1) file name lookup. This also means that typed array/Buffer assets are no longer deduplicated for performance reasons.
  • To avoid a performance issue when using many unnamed assets, reference ids are now generated using a counter as id base for those assets (otherwise, they would use the same base which would lead to a very slow re-hashing process).

@lukastaegert
Improve performance of asset emissions
8d6dd2f 
BREAKING CHANGES: Typed array sources will no longer be deduplicated
@github-actions
Copy link

github-actions bot commented Sep 23, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#improve-asset-emission-performance

or load it into the REPL:
https://rollupjs.org/repl/?pr=4644

@lukastaegert lukastaegert changed the base branch from master to release-3.0.0 September 23, 2022 04:39
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #4644 (8d6dd2f) into release-3.0.0 (52d9ca2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           release-3.0.0    #4644      +/-   ##
=================================================
- Coverage          98.97%   98.97%   -0.01%     
=================================================
  Files                213      213              
  Lines               7492     7481      -11     
  Branches            2116     2112       -4     
=================================================
- Hits                7415     7404      -11     
  Misses                23       23              
  Partials              54       54
Impacted Files Coverage Δ
src/utils/FileEmitter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 8015be7 into release-3.0.0 Sep 23, 2022
@lukastaegert lukastaegert deleted the improve-asset-emission-performance branch September 23, 2022 04:41
@lukastaegert lukastaegert mentioned this pull request Sep 23, 2022
Merged
9 tasks
@rollup-bot
Copy link
Collaborator

rollup-bot commented Sep 23, 2022

This PR has been released as part of rollup@3.0.0-7. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-7 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Oct 10, 2022
@lukastaegert
[v3.0] Improve performance of asset emissions (#4644)
74db335 
BREAKING CHANGES: Typed array sources will no longer be deduplicated

3.0.0-7
@rollup-bot
Copy link
Collaborator

rollup-bot commented Oct 11, 2022

This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.0.0-8 or npm install rollup@beta. It will likely become part of a regular release later.

lukastaegert added a commit that referenced this pull request Oct 11, 2022
@lukastaegert
[v3.0] Improve performance of asset emissions (#4644)
c0ab48b 
BREAKING CHANGES: Typed array sources will no longer be deduplicated

3.0.0-7
@rollup-bot
Copy link
Collaborator

rollup-bot commented Oct 11, 2022

This PR has been released as part of rollup@3.0.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukastaegert @rollup-bot