feat(node-resolve): preserve search params and hashes#487
Merged
shellscape merged 1 commit intorollup:masterfrom Jul 12, 2020
Merged
feat(node-resolve): preserve search params and hashes#487shellscape merged 1 commit intorollup:masterfrom
shellscape merged 1 commit intorollup:masterfrom
Conversation
shellscape
approved these changes
Jul 9, 2020
Collaborator
|
@LarsDenBakker we'll give this another day or so for folks to put eyes on it before we merge. |
This was referenced Aug 9, 2020
LarsDenBakker
added a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
This was referenced Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: Fixes #486
Description
This makes node-resolve preserve any search params or hashes if they were in the import path.
Code:
Before this change it would throw, saying it can't find
my-package?foo=bar'.After this change, it gets resolved to something like:
This would still throw as rollup tries to find this file, but a rollup plugin can set up a special load for a module with this parameter.