Fix Node Protocol plugin to handle node-only modules correctly#483
Closed
Fix Node Protocol plugin to handle node-only modules correctly#483
Conversation
Contributor
Author
|
@sxzz 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: sxzz <6481596+sxzz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Node Protocol plugin needs to handle Node Protocol only modules
Fix Node Protocol plugin to handle node-only modules correctly
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node Protocol plugin was incorrectly handling modules that require the
node:prefix and modules that already have the prefix. This caused two main issues:Double prefixing: When
nodeProtocol: truewas used, modules that already had thenode:prefix would get another prefix added, resulting innode:node:pathinstead ofnode:path.Stripping required prefixes: When
nodeProtocol: 'strip'was used, modules that REQUIRE thenode:prefix (likenode:test,node:sqlite,node:sea,node:test/reporters) would have their prefix stripped, making them invalid.Example of the problem:
Solution:
For adding mode (
nodeProtocol: true): Check if modules already have thenode:prefix and preserve them as-is instead of adding another prefix.**For stripping mode (
nodeProtocol: 'strip')**: Identify modules that require thenode:prefix (node:sea,node:sqlite,node:test,node:test/reporters`) and preserve their prefix even in strip mode.After fix:
The fix includes comprehensive test cases to validate both scenarios and maintains backward compatibility with existing functionality.
Fixes #482.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.