Merged
Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sxzz
approved these changes
Jul 18, 2025
Member
|
Thanks bro! |
commit: |
Member
|
@posva I reverted this PR via 7c32a1d because:
export function defineConfig(options: UserConfig): UserConfig;
export function defineConfig(options: UserConfigFn): UserConfigFn;
export function defineConfig(
options: UserConfig | UserConfigFn,
): UserConfig | UserConfigFn;
After evaluating these options, I decided to go with overloading, as Vite does. If you need to achieve type inference, using |
Contributor
Author
|
Of course, I didn’t expect it to break jump to definition. TIL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
defineConfig({}), the return value cannot be spread because the type includes a function. Since thedefineConfig()is just the identity function, it might be better to keep the type as is. Another option is to create an overload functionLinked Issues
Additional context
The current workaround is to use
satisfies UserOptions