Skip to content

feat: add option named for invalid return type errors for more places#9822

Merged
shulaoda merged 1 commit into
06-16-feat_add_option_names_for_invalid_return_type_errorsfrom
06-16-feat_add_option_named_for_invalid_return_type_errors_for_more_places
Jun 18, 2026
Merged

feat: add option named for invalid return type errors for more places#9822
shulaoda merged 1 commit into
06-16-feat_add_option_names_for_invalid_return_type_errorsfrom
06-16-feat_add_option_named_for_invalid_return_type_errors_for_more_places

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Added the message introduced in #9821 to more places.

close #9005

@sapphi-red Graphite App

sapphi-red commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Jun 17, 2026
Merged
@sapphi-red sapphi-red marked this pull request as ready for review June 17, 2026 08:21
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks1

Comparing 06-16-feat_add_option_named_for_invalid_return_type_errors_for_more_places (c3c6219) with 06-16-feat_add_option_names_for_invalid_return_type_errors (1ecbf63)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sapphi-red sapphi-red requested a review from shulaoda June 17, 2026 08:37
@sapphi-red Graphite App

sapphi-red commented Jun 17, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

  • Jun 17, 8:37 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 17, 2:27 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jun 17, 2:34 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #9821.
  • Jun 17, 2:34 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #9821.

@graphite-app graphite-app Bot force-pushed the 06-16-feat_add_option_names_for_invalid_return_type_errors branch from 1ecbf63 to 9c94723 Compare June 17, 2026 14:32
@graphite-app graphite-app Bot requested a review from IWANABETHATGUY as a code owner June 17, 2026 14:32
@graphite-app graphite-app Bot force-pushed the 06-16-feat_add_option_named_for_invalid_return_type_errors_for_more_places branch from c3c6219 to 8680dee Compare June 17, 2026 14:33
@shulaoda shulaoda self-assigned this Jun 17, 2026
@shulaoda shulaoda merged commit d0155a2 into 06-16-feat_add_option_names_for_invalid_return_type_errors Jun 18, 2026
27 of 29 checks passed
@shulaoda shulaoda deleted the 06-16-feat_add_option_named_for_invalid_return_type_errors_for_more_places branch June 18, 2026 03:54
@shulaoda

shulaoda commented Jun 18, 2026

Copy link
Copy Markdown
Member

Sorry, I made a mistake 😨

@shulaoda shulaoda restored the 06-16-feat_add_option_named_for_invalid_return_type_errors_for_more_places branch June 18, 2026 03:57
@shulaoda

shulaoda commented Jun 18, 2026

Copy link
Copy Markdown
Member

@sapphi-red Would you mind reopen a PR?

@shulaoda shulaoda mentioned this pull request Jun 18, 2026
Merged
shulaoda added a commit that referenced this pull request Jun 18, 2026
@shulaoda @sapphi-red
feat: add option named for invalid return type errors for more places (…
8dfcb8d 
…#9846)

Reopen of #9822

Added the message introduced in #9821 to more places.

close #9005

---------

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes
@shulaoda shulaoda Awaiting requested review from shulaoda
@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees

@shulaoda shulaoda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @shulaoda @hyf0