refactor(link_stage): detach depended_runtime_helper from EcmaView to remove unsafe#9265
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 30, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
8b5ffdd to
fb5d22e
Compare
63f514d to
bf0f22f
Compare
This was referenced Apr 29, 2026
fb5d22e to
54f5bef
Compare
bf0f22f to
77f7a0e
Compare
54f5bef to
703195f
Compare
77f7a0e to
1a9891f
Compare
119d78c to
30538df
Compare
1a9891f to
32ec354
Compare
30538df to
0ef96a7
Compare
568bc9a to
a7e5cbd
Compare
a7e5cbd to
1871b1d
Compare
9d8a01c to
5eecace
Compare
1871b1d to
fbb45af
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
h-a-n-a
approved these changes
Apr 30, 2026
Member
Author
Merge activity
|
… remove unsafe (#9265) ## Summary Lift the per-module `depended_runtime_helper` map out of `EcmaView` into a parallel `IndexVec<ModuleIdx, Box<DependedRuntimeHelperMap>>` on `LinkStage`. This lets `reference_needed_symbols` mutate the map through a safe `par_iter_mut().zip(...)` pipeline instead of casting away `&` via `addr_of!`, eliminating the second remaining `unsafe` block in that pass. related to #9242, which removed the analogous unsafe for `stmt_infos`. ## Changes - Add `depended_runtime_helper` field on `LinkStage` and initialize it alongside the module table. - Remove `depended_runtime_helper` from `EcmaView` and its two construction sites (`ecma_module_view_factory`, `runtime_module_task`). - `reference_needed_symbols`: zip the new field into the parallel walk; drop the `unsafe { &mut *addr_of!(importer.depended_runtime_helper).cast_mut() }` block. - `include_statements`: read the map from its new home via a parallel zip.
fbb45af to
4672704
Compare
Merged
shulaoda
added a commit
that referenced
this pull request
May 7, 2026
## [1.0.0] - 2026-05-07 ### 🐛 Bug Fixes - dev/lazy: lazily compiled modules should be watched (#9301) by @h-a-n-a - implement dynamic dominator merge logic (#9270) by @TheAlexLichter - dev: apply __toCommonJS interop when CJS requires ESM in HMR finalizer (#9261) by @h-a-n-a ### 🚜 Refactor - ecma_ast: tighten allocator access to enforce Sync invariant (#9278) by @IWANABETHATGUY - scan_stage: remove stmt_infos field from EcmaView (#9276) by @IWANABETHATGUY - link_stage: detach stmt_infos from EcmaView (#9274) by @IWANABETHATGUY - link_stage: detach depended_runtime_helper from EcmaView to remove unsafe (#9265) by @IWANABETHATGUY - link_stage: remove unsafe in determine_module_exports_kind (#9253) by @IWANABETHATGUY ### 📚 Documentation - getting-started: remove RC warning for 1.0.0 release (#9310) by @shulaoda - getting-started: update version references for 1.0.0 release (#9309) by @shulaoda - add Vite+ tab to getting-started snippets (#9285) by @shulaoda - lazy-barrel: clarify own-exports behavior for import-then-export records (#9298) by @shulaoda - restructure top navigation around Learn vs Reference (#9284) by @shulaoda - builtin-plugins: add bundle analyzer plugin docs (#9292) by @shulaoda - design doc for reference_needed_symbols (#9264) by @IWANABETHATGUY ### ⚡ Performance - devtools: write logs on a background thread (#9219) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - mark esbuild/ts/parameter_props_use_define_for_class_fields_true as passed (#9308) by @sapphi-red - deps: upgrade oxc to 0.129.0 (#9297) by @shulaoda - deps: update rollup submodule for tests to v4.60.3 (#9294) by @sapphi-red - deps: update test262 submodule for tests (#9295) by @sapphi-red - ai: add rolldown REPL decode skill (#9245) by @Dunqing
pull Bot
pushed a commit
to olrtg/rolldown
that referenced
this pull request
May 7, 2026
## [1.0.0] - 2026-05-07 ### 🐛 Bug Fixes - dev/lazy: lazily compiled modules should be watched (rolldown#9301) by @h-a-n-a - implement dynamic dominator merge logic (rolldown#9270) by @TheAlexLichter - dev: apply __toCommonJS interop when CJS requires ESM in HMR finalizer (rolldown#9261) by @h-a-n-a ### 🚜 Refactor - ecma_ast: tighten allocator access to enforce Sync invariant (rolldown#9278) by @IWANABETHATGUY - scan_stage: remove stmt_infos field from EcmaView (rolldown#9276) by @IWANABETHATGUY - link_stage: detach stmt_infos from EcmaView (rolldown#9274) by @IWANABETHATGUY - link_stage: detach depended_runtime_helper from EcmaView to remove unsafe (rolldown#9265) by @IWANABETHATGUY - link_stage: remove unsafe in determine_module_exports_kind (rolldown#9253) by @IWANABETHATGUY ### 📚 Documentation - getting-started: remove RC warning for 1.0.0 release (rolldown#9310) by @shulaoda - getting-started: update version references for 1.0.0 release (rolldown#9309) by @shulaoda - add Vite+ tab to getting-started snippets (rolldown#9285) by @shulaoda - lazy-barrel: clarify own-exports behavior for import-then-export records (rolldown#9298) by @shulaoda - restructure top navigation around Learn vs Reference (rolldown#9284) by @shulaoda - builtin-plugins: add bundle analyzer plugin docs (rolldown#9292) by @shulaoda - design doc for reference_needed_symbols (rolldown#9264) by @IWANABETHATGUY ### ⚡ Performance - devtools: write logs on a background thread (rolldown#9219) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - mark esbuild/ts/parameter_props_use_define_for_class_fields_true as passed (rolldown#9308) by @sapphi-red - deps: upgrade oxc to 0.129.0 (rolldown#9297) by @shulaoda - deps: update rollup submodule for tests to v4.60.3 (rolldown#9294) by @sapphi-red - deps: update test262 submodule for tests (rolldown#9295) by @sapphi-red - ai: add rolldown REPL decode skill (rolldown#9245) by @Dunqing Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lift the per-module
depended_runtime_helpermap out ofEcmaViewinto a parallelIndexVec<ModuleIdx, Box<DependedRuntimeHelperMap>>onLinkStage. This letsreference_needed_symbolsmutate the map through a safepar_iter_mut().zip(...)pipeline instead of casting away&viaaddr_of!, eliminating the second remainingunsafeblock in that pass.related to #9242, which removed the analogous unsafe for
stmt_infos.Changes
depended_runtime_helperfield onLinkStageand initialize it alongside the module table.depended_runtime_helperfromEcmaViewand its two construction sites (ecma_module_view_factory,runtime_module_task).reference_needed_symbols: zip the new field into the parallel walk; drop theunsafe { &mut *addr_of!(importer.depended_runtime_helper).cast_mut() }block.include_statements: read the map from its new home via a parallel zip.