refactor(link_stage): simplify exports-kind filter and clarify safety comments#9178
Merged
IWANABETHATGUY merged 0 commit into04-20-docs_compute_tla_designfrom Apr 22, 2026
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
f642a48 to
e780042
Compare
e780042
into
04-20-docs_compute_tla_design
5 of 6 checks passed
6714f4a to
14a1a08
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 22, 2026
… comments (#9205) Collapse the two-step `filter_map` + `for_each` in `determine_module_exports_kind` so the iterator yields `(rec, &NormalModule)` directly via `Module::as_normal`, removing the inline `let-else` inside the closure. Also rewrites the `SAFETY:` and promotion comments to be clearer about what each branch does and why self-import aliasing is safe. Note: replaces #9178 which was auto-closed as merged after a stack reorder (GitHub detected all its commits were in its former base branch). Same content, now targeting main directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse the two-step
filter_map+for_eachindetermine_module_exports_kindso the iterator yields(rec, &NormalModule)directly viaModule::as_normal, removing the inlinelet-elseinside the closure. Also rewrites theSAFETY:and promotion comments to be clearer about what each branch does and why self-import aliasing is safe.