• chore(rolldown): use bounded channel to avoid dynamic memory allocation #872 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite

✅ Deploy Preview for rolldown-rs canceled.

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.31%. Comparing base (5106eda) to head (e60dc50).
Report is 1 commits behind head on main.

❗ Current head e60dc50 differs from pull request most recent head d25fcc1. Consider uploading reports for the commit d25fcc1 to get more accurate results

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   78.31%   78.31%           
=======================================
  Files         137      137           
  Lines        6847     6849    +2     
=======================================
+ Hits         5362     5364    +2     
  Misses       1485     1485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Do we do this only for supporting wasi? Unounded channel is not usable in wasi target?

CodSpeed Performance Report

Merging #872 will not alter performance

_{Comparing 04-15-chore_rolldown_use_bounded_channel_to_avoid_dynamic_memory_allocation (d25fcc1) with main (8fc0769)}

Summary

✅ 6 untouched benchmarks

Benchmark shows it slower than the UnboundedChannel, I'll take a look

Benchmark shows it slower than the UnboundedChannel, I'll take a look

Could be just noise. I also benchmark it locally. Seems fine.